Add option to exclude boto3 and botocore from dependencies #2525
+261
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
added
the
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-pczajka
commented
Sep 10, 2025
setup.py
Outdated
|
|
||
| # Check if slim is being requested via environment variable | ||
| # (This is the most reliable way to detect slim installation intent) | ||
| is_slim_install = os.environ.get("SNOWFLAKE_SLIM_INSTALL", "").lower() in ( |
There was a problem hiding this comment.
Refactor
Suggested change
| is_slim_install = os.environ.get("SNOWFLAKE_SLIM_INSTALL", "").lower() in ( | |
| is_slim_install = os.environ.get("SNOWFLAKE_NO_BOTO", "").lower() in ( |
sfc-gh-pczajka
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfc-gh-pczajka
changed the title
| deactivate | ||
| rm -rf test_default_env | ||
|
|
||
| - name: Test installation with SNOWFLAKE_NO_BOTO=1 (should exclude boto) |
There was a problem hiding this comment.
Could we make this more generally into a slim package, in case we need to include additional dependencies in the near future?
Example: we're discovering more gaps in our WIF client-side story on Azure because we're rolling our own client library rather than using Microsoft's MSAL libraries. It would be nice to have the option to bundle MSAL later.
Having a slim package would give flexibility to include such dependencies, rather than a "noboto" package which only seems to be related to AWS boto.
| @@ -152,6 +158,12 @@ def create_aws_attestation( | |||
|
|
|||
| If the application isn't running on AWS or no credentials were found, raises an error. | |||
| """ | |||
| if not BOTO_AVAILABLE: | |||
| raise MissingDependencyError( | |||
| msg="boto3 or botocore dependency is not installed. [boto] extension is required for the AWS provider.", | |||
There was a problem hiding this comment.
Suggest a more user-facing and actionable error message:
Suggested change
| msg="boto3 or botocore dependency is not installed. [boto] extension is required for the AWS provider.", | |
| msg="AWS Workload Identity Federation is not supported in the slim snowflake-python-connect build. Please update your pip dependencies to use the full connector package instead.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-2107016
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR introduces an option to install
snowflake-connector-pythonwithout boto3 and botocore dependenciesIt includes as well: