Skip to content

Conversation

sfc-gh-bchinn
Copy link
Contributor

@sfc-gh-bchinn sfc-gh-bchinn commented Sep 11, 2025

Port PR: https://github.com/snowflakedb/Stored-Proc-Python-Connector/pull/225

I noticed that get_results_from_sfqid assumes that fetchall returns a tuple when that's not necessarily the case. Fixing it here + adding a test that fails without the fix.

E                   AssertionError: assert [{'multiple s...ccessfully.'}] == [{'1': 1}]
E                     At index 0 diff: {'multiple statement execution': 'Multiple statements executed successfully.'} != {'1': 1}
E                     Full diff:
E                     - [{'1': 1}]
E                     + [{'multiple statement execution': 'Multiple statements executed successfully.'}]

Copy link
Contributor Author

sfc-gh-bchinn commented Sep 11, 2025

@sfc-gh-bchinn sfc-gh-bchinn changed the title Add test for get_results_from_sfqid with DictCursor Fix get_results_from_sfqid with DictCursor + multi statements Sep 11, 2025
@sfc-gh-bchinn sfc-gh-bchinn marked this pull request as ready for review September 11, 2025 20:34
@sfc-gh-bchinn sfc-gh-bchinn requested a review from a team as a code owner September 11, 2025 20:34
@sfc-gh-bchinn sfc-gh-bchinn merged commit 29b5b7e into main Sep 16, 2025
93 of 99 checks passed
@sfc-gh-bchinn sfc-gh-bchinn deleted the bchinn-dict-cursor-sfqid branch September 16, 2025 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants