Fix documentation build properly#1456
Merged
Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.6.8from Oct 21, 2025
Merged
Fix documentation build properly#1456Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.6.8from
Jethro Nederhof (jethron) merged 1 commit intosnowplow:release/4.6.8from
Conversation
Not sure what part of the escaping is failing here, so removing all the ambiguity.
Jethro Nederhof (jethron)
force-pushed
the
fix/docs-build
branch
from
6170836 to
cdf3060
Compare
Jethro Nederhof (jethron)
requested review from
Matus Tomlein (matus-tomlein)
and removed request for
Costas Kotsokalis (cksnp)
Matus Tomlein (matus-tomlein)
approved these changes
Oct 19, 2025
Jethro Nederhof (jethron)
merged commit 1f7a319
into
snowplow:release/4.6.8
1 check failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1444 which tried to fix our API docs build, but ended up being unsuccessful once the release CI job actually ran.
Probably because we're on pretty old versions of things, something is getting confused with the nested JSX-in-markdown-in-JSX; I thought I'd managed to escape it properly in that change but it still didn't work.
So this change just removes the nested JSX, removing all the ambiguity, which fixes the build properly.