Skip to content

[pull] main from mne-tools:main #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

[pull] main from mne-tools:main #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09b3da
FIX: Fix _plot_topomap channel names plotting when using a mask (#13470)
mistraube Oct 30, 2025
1815534
typo in mailmap (#13475)
drammock Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .mailmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ Mathieu Scheltienne <[email protected]> Mathieu Scheltienne <7389361
Mathieu Scheltienne <[email protected]> Mathieu Scheltienne <[email protected]>
Mathurin Massias <[email protected]> mathurinm <[email protected]>
Mathurin Massias <[email protected]> mathurinm <[email protected]>
Mats van Es <[email protected]> Mats <[email protected]
Mats van Es <[email protected]> Mats <[email protected]>
Matt Sanderson <[email protected]> monkeyman192 <[email protected]>
Matteo Anelli <[email protected]> Matteo Anelli <[email protected]>
Matteo Visconti di Oleggio Castello <[email protected]> Matteo Visconti dOC <[email protected]>
Expand Down
1 change: 1 addition & 0 deletions doc/changes/dev/13470.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug with :func:`mne.viz.plot_topomap` that caused unexpected channel name plotting when using a mask, by `Michael Straube`_.
7 changes: 2 additions & 5 deletions mne/viz/topomap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,11 +1422,8 @@ def _plot_topomap(
if isinstance(outlines, dict):
_draw_outlines(axes, outlines)

if names is not None:
show_idx = np.arange(len(names)) if mask is None else np.where(mask)[0]
for ii, (_pos, _name) in enumerate(zip(pos, names)):
if ii not in show_idx:
continue
if names is not None and sensors:
for _pos, _name in zip(pos, names):
axes.text(
_pos[0],
_pos[1],
Expand Down
Loading