Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perf enhancement for snyk monitor #5272

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthogez
Copy link
Member

@anthogez anthogez commented May 29, 2024

Rather than have post monitor working 1 by 1, we are trying to achieve an initial
and minimal concurrency of 5 monitor requests at once

@anthogez anthogez force-pushed the feat/perf-enhancement-for-snyk-monitor branch from ee83608 to f0c678c Compare May 29, 2024 13:32
@anthogez anthogez changed the title wip Perf Enhancement Snyk Monitor May 29, 2024
@snyk snyk deleted a comment from github-actions bot May 29, 2024
Copy link
Contributor

github-actions bot commented May 29, 2024

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/commands/monitor/index.ts
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against fecbcab

@anthogez anthogez force-pushed the feat/perf-enhancement-for-snyk-monitor branch from f0c678c to c3760c6 Compare May 29, 2024 13:54
@anthogez anthogez changed the title Perf Enhancement Snyk Monitor feat: perf enhancement for snyk monitor May 29, 2024
@anthogez anthogez force-pushed the feat/perf-enhancement-for-snyk-monitor branch from c3760c6 to ab631ad Compare May 29, 2024 13:55
@anthogez anthogez marked this pull request as ready for review May 29, 2024 13:55
@anthogez anthogez requested a review from a team as a code owner May 29, 2024 13:55
@anthogez anthogez marked this pull request as draft May 29, 2024 13:56
@anthogez anthogez force-pushed the feat/perf-enhancement-for-snyk-monitor branch from ab631ad to b568d3d Compare June 17, 2024 09:12
@anthogez anthogez marked this pull request as ready for review June 17, 2024 09:12
Rather than have post monitor working 1 by 1, we are trying to achieve an initial
and minimal concurrency of 5 monitor requests at once
@anthogez anthogez force-pushed the feat/perf-enhancement-for-snyk-monitor branch from b568d3d to fecbcab Compare July 9, 2024 14:06
const { scannedProjects } = multiProjectResult;

const results: Array<GoodResult | BadResult> = [];
const MAX_CONCURRENCY = 5;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Let's be a bit more pessimistic to not increase the load too much and set it to a lower value first. Let's start with 2.

@thisislawatts thisislawatts marked this pull request as draft September 12, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants