-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: perf enhancement for snyk monitor #5272
base: main
Are you sure you want to change the base?
Conversation
ee83608
to
f0c678c
Compare
|
f0c678c
to
c3760c6
Compare
c3760c6
to
ab631ad
Compare
ab631ad
to
b568d3d
Compare
Rather than have post monitor working 1 by 1, we are trying to achieve an initial and minimal concurrency of 5 monitor requests at once
b568d3d
to
fecbcab
Compare
const { scannedProjects } = multiProjectResult; | ||
|
||
const results: Array<GoodResult | BadResult> = []; | ||
const MAX_CONCURRENCY = 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Let's be a bit more pessimistic to not increase the load too much and set it to a lower value first. Let's start with 2.
Rather than have post monitor working 1 by 1, we are trying to achieve an initial
and minimal concurrency of 5 monitor requests at once