feat: add support for PATs, allow to select reference directory for delta scans [IDE-846] #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
force-pushed
the
feat/IDE-846_add-command-to-set-reference-folder
branch
2 times, most recently
from
aec2ad7 to
7b5dd1a
Compare
bastiandoetsch
changed the title
…[IDE-46] This change introduces the ability to select a reference *directory* for delta findings in addition to the existing option of selecting a reference *branch*. Let's break down the changes and offer some suggestions: **Key Changes & Improvements:** * **`SNYK_SET_DELTA_REFERENCE_COMMAND` replaces `SNYK_SET_BASE_BRANCH_COMMAND`:** This makes the command more generic, reflecting its expanded functionality. * **`getReference()` replaces `getBaseBranch()`:** Again, for generality. * **New `referenceFolderPath` in `FolderConfig`:** Stores the path to the reference directory. * **New `setReferenceFolder()` command and logic:** Handles selecting and saving the reference directory. * **QuickPick for Reference Selection:** Users now choose between "Select a reference branch" and "Select a reference directory" before proceeding. * **PAT Validation:** Added a `patValidate` function to the `AuthenticationService` to properly validate Personal Access Tokens. * **Mocking Improvements:** Added `showOpenDialog` to the window mock for better testing.
This change adds spaces around the colon in the "Click here to choose reference" text displayed when delta findings are enabled. The original text was `[ current:${reference} ]`, and the updated text is `[ current: ${reference} ]`. This improves readability slightly.
…nto feat/IDE-846_add-command-to-set-reference-folder
bastiandoetsch
force-pushed
the
feat/IDE-846_add-command-to-set-reference-folder
branch
from
86368f7 to
d73c0ef
Compare
bastiandoetsch
deleted the
feat/IDE-846_add-command-to-set-reference-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: allow to define reference directory for delta, allow Snyk PATs
This change introduces the ability to select a reference directory for delta findings in addition to the existing option of selecting a reference branch. Let's break down the changes:
Key Changes & Improvements:
SNYK_SET_DELTA_REFERENCE_COMMANDreplacesSNYK_SET_BASE_BRANCH_COMMAND: This makes the command more generic, reflecting its expanded functionality.getReference()replacesgetBaseBranch(): Again, for generality.referenceFolderPathinFolderConfig: Stores the path to the reference directory.setReferenceFolder()command and logic: Handles selecting and saving the reference directory.patValidatefunction to theAuthenticationServiceto properly validate Personal Access Tokens.showOpenDialogto the window mock for better testing.Checklist
Screenshots / GIFs