-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSP]Returning tenantId of buckets when listing out the buckets #1308
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
=======================================
Coverage 48.12% 48.12%
=======================================
Files 10 10
Lines 1571 1571
=======================================
Hits 756 756
Misses 756 756
Partials 59 59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vineela1999 The response already has a <Owner></Owner>
tag.
This tag refers to the owner of the buckets.
Now if a tenantId
is returned as part of the bucket metadata will this <Owner>
tag still be returned?
@anvithks OwnerID here is used in the sense who requested for list buckets and each tenantId is who created the bucket |
@vineela1999 Owner in response to a GET buckets call will mean the owner of the bucket. |
What type of PR is this?
kind enhancement
What this PR does / why we need it:
This PR is required to give tenantId of each buckets when listing down the buckets
To implement the usecase that When Admin is trying to list buckets buckets created by buckets should only have operations
Non-admin user created buckets should only be in read mode
Which issue(s) this PR fixes:
Fixes #1297 (bucket visibility of admin)
Test Report Added?:
kind TESTED
Test Report:
Now,list buckets is showing tenantID of each bucket:
Special notes for your reviewer: