[SofaBaseLinearSolver] Remove the IsRequired flag in CGLinearSolver #2498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 2419 restores the correct behavior of CGLinearSolver regarding the call-super-init sofa-framework#2419 But as some of its data are tagged as Required, this rise en error message when the value is not set by the user. I'm not sure it is wise to use the required flag when data provides meaningful and usable default values. So I recommand removing it.
damienmarchal
added
pr: fix
Contributor
|
I will work on an alternative proposal |
hugtalbot
removed
the
pr: status to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2419 restores the correct behavior of CGLinearSolver regarding the call-super-init
#2419
But as some of its data are tagged as Required, this rise an error message when the value
is not set by the user.
I'm not sure it is wise to set the required flag when data provides meaningful and usable default values.
I recommand removing it and more generally keep the isRequired only for data field that really have no possibility to have a default value (eg: the filename for a loader).
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if