Upgrade version and replace images by unicode text #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebryu
requested changes
Jul 25, 2018
src/plugin.js
Outdated
| @@ -330,7 +330,7 @@ const plugin = (editor) => { | |||
| editor.addButton('asciimath', { | |||
| tooltip : 'Add New Math', | |||
| cmd : 'mceAsciimath', | |||
| image : url + '/img/ed_mathformula2.gif' | |||
| text: '\u03A3' | |||
There was a problem hiding this comment.
Actually this icon was with + sign. My client that uses this plugin is really attached to it so I'd rather not change it.
gcusnieux
commented
Jul 25, 2018
src/plugin.js
Outdated
| @@ -345,7 +345,7 @@ const plugin = (editor) => { | |||
| editor.addButton('asciimathcharmap', { | |||
| tooltip : 'Math Symbols', | |||
| cmd : 'mceAsciimathDlg', | |||
| image : url + '/img/ed_mathformula.gif' | |||
| text: '\u03A3+' | |||
| }); | |||
There was a problem hiding this comment.
I understand, but this icon has + sign : "\u03A3+" = Σ+
There was a problem hiding this comment.
What I mean is the order of those icons.
First one (named ed_mathformula2.gif) is with a + sign, so text: '\u03A3+' should be above (line: 333), and here should be just text: '\u03A3' without + sign
gcusnieux
force-pushed
the
master
branch
2 times, most recently
from
e88f72f
to
8aef3b3
Compare
|
@sebryu I rewrite the commit with good icons and add some fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.