-
-
Notifications
You must be signed in to change notification settings - Fork 42
fix: Align @geometry with main #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
pkg.pr.new packages benchmark commit |
8e7e2c6 to
582630b
Compare
aleksanderkatan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Do we plan on keeping these examples as dev only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know about these issues. I have this new PR open which rewrites the implementation, then I'll think about what to do in these specific cases. It is not completely obvious to me what strategy is visually best yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait, this exact issue I have not seen before. But maybe look at the new implementation PR and see if you can rebase your changes. I have already aligned (all?) the implementations with recent main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another look, and indeed this happens when you try using "arrow" caps. They are kinda fiddly in terms of cases where they work nicely. When there is such a short and thick segment, the arrow is way bigger than it, causing the issue you are seeing. So in this case, yes it is expected.
Yes, until we publish the @typegpu/geometry package. |

Closes #1930.