Skip to content

Remove stft calculation within the encoder #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove stft calculation within the encoder #635

wants to merge 3 commits into from

Conversation

chmjkb
Copy link
Contributor

@chmjkb chmjkb commented Oct 3, 2025 •
edited
Loading

Description

The Whisper model export now takes in a plain waveform instead of pre-computed STFT. This PR aims to change the current API to accept waveforms instead. Before merging this, make sure to re-export all the existing Whisper models with the new export script.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb linked an issue Oct 3, 2025 that may be closed by this pull request
Remove STFT calculation in STT #634
Open
@msluszniak msluszniak changed the title feat: remove stft calculation within the encoder Remove stft calculation within the encoder Oct 6, 2025
@msluszniak msluszniak added model Issues related to exporting, improving, fixing ML models refactoring feature PRs that implement a new feature improvement PRs or issues focused on improvements in the current codebase and removed refactoring labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature PRs that implement a new feature improvement PRs or issues focused on improvements in the current codebase model Issues related to exporting, improving, fixing ML models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove STFT calculation in STT
2 participants
@chmjkb @msluszniak