Skip to content

[General] Replace enabled with disabled prop on Clickable #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-piasecki merged 2 commits into from
Apr 13, 2026
+9 −2
Merged

[General] Replace enabled with disabled prop on Clickable #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78b5a18
Invert enabled prop
j-piasecki Apr 3, 2026
92b1df6
Merge branch 'main' into @jpiasecki/clickable-disabled
j-piasecki Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/common-app/src/new_api/components/touchable_stress/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export default function TouchableStress() {
activeUnderlayOpacity={0.105}
style={[styles.startButton, isRunning && styles.startButtonBusy]}
onPress={start}
enabled={!isRunning}>
disabled={isRunning}>
<Text style={styles.startButtonText}>
{isRunning ? `Running ${currentRun}/${N}...` : 'Start test'}
</Text>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-gesture-handler/src/v3/components/Touchable/Touchable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const Touchable = (props: TouchableProps) => {
onPressOut,
onActiveStateChange,
children,
disabled = false,
ref,
...rest
} = props;
Expand Down Expand Up @@ -115,6 +116,7 @@ export const Touchable = (props: TouchableProps) => {
{...rest}
{...rippleProps}
ref={ref ?? null}
enabled={!disabled}
onBegin={onBegin}
onActivate={onActivate}
onDeactivate={onDeactivate}
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native-gesture-handler/src/v3/components/Touchable/TouchableProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type PressableAndroidRippleConfig = {

type RippleProps = 'rippleColor' | 'rippleRadius' | 'borderless' | 'foreground';

export type TouchableProps = Omit<ButtonProps, RippleProps> &
export type TouchableProps = Omit<ButtonProps, RippleProps | 'enabled'> &
Omit<BaseButtonProps, keyof RawButtonProps> & {
/**
* Configuration for the ripple effect on Android.
Expand All @@ -31,4 +31,9 @@ export type TouchableProps = Omit<ButtonProps, RippleProps> &
* Called when pointer is released from the component.
*/
onPressOut?: ((event: CallbackEventType) => void) | undefined;

/**
* Whether the component should ignore touches. By default set to false.
*/
disabled?: boolean | undefined;
};
Loading