feat(Worklets): actionable error when passing local function to scheduleOnRN#9386
Draft
tjzel wants to merge 16 commits into
Draft
feat(Worklets): actionable error when passing local function to scheduleOnRN#9386tjzel wants to merge 16 commits into
scheduleOnRN#9386tjzel wants to merge 16 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressing a long overdue issue, where passing a locally defined function to
scheduleOnRNwould crash the app with a vague stack trace.This PR adds an actionable error in such cases. I had to refactor a bunch of code for that but even more changes are coming in #9272.
Test plan
TODO