Worklets: fixed memleak in shareable and serializable#9393
Open
tshmieldev wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a small but repeated memory leak when retaining jsi::Value wrappers after their owning JSI runtime has been torn down, by freeing the heap allocation while still intentionally skipping ~jsi::Value to avoid use-after-free crashes.
Changes:
- In
Shareable::~Shareable, when the host runtime is gone, free the releasedjsi::Valuewrapper allocation via::operator delete(...)instead of leaking it. - In
cleanupIfRuntimeExists, when a runtime is no longer alive, free the releasedjsi::Valuewrapper allocation via::operator delete(...)instead of leaking it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/react-native-worklets/Common/cpp/worklets/SharedItems/Shareable.cpp | Frees the jsi::Value wrapper allocation when skipping destruction after host runtime teardown. |
| packages/react-native-worklets/Common/cpp/worklets/SharedItems/Serializable.h | Frees the jsi::Value wrapper allocation in the “runtime dead” cleanup path while still skipping ~jsi::Value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomekzaw
reviewed
May 12, 2026
tomekzaw
reviewed
May 12, 2026
tomekzaw
reviewed
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
we did .release() on jsi value without freeing the memory, leaking ~20B per instance
fixed
👽
Test plan
Stuff works, allocation 1_000_000 jsi values in cpp and then releasing them leaks
but after ::operator delete'ing them no leak