Open
Conversation
sgaczol
requested review from
Copilot,
kkafar,
kligarski,
kmichalikk and
t0maboro
and removed request for
Copilot,
kmichalikk and
t0maboro
kligarski
reviewed
May 4, 2026
Contributor
kligarski
left a comment
kligarski
left a comment
There was a problem hiding this comment.
Looks good but I have some suggestions/questions.
Contributor
There was a problem hiding this comment.
It would be nice to follow new test convention (separate directory, scenario.md).
| }, | ||
| content: { | ||
| padding: 20, | ||
| paddingTop: Platform.OS === 'android' ? 60 : undefined, |
Contributor
There was a problem hiding this comment.
Suggested change
| paddingTop: Platform.OS === 'android' ? 60 : undefined, |
| setHostColorScheme: (value: SplitHostColorScheme) => void; | ||
| }) { | ||
| return ( | ||
| <ScrollView style={styles.container} contentContainerStyle={styles.content}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ScrollView style={styles.container} contentContainerStyle={styles.content}> | |
| <ScrollView | |
| style={styles.container} | |
| contentContainerStyle={styles.content} | |
| contentInsetAdjustmentBehavior="automatic"> |
This will correctly offset the content in the column.
| platforms: ['ios'], | ||
| }; | ||
|
|
||
| export function ConfigColumn({ |
Contributor
There was a problem hiding this comment.
Once again I see this - is this a native bug?
Collaborator
Author
There was a problem hiding this comment.
Adding contentInsetAdjustmentBehavior="automatic" and using SafeAreaView fixed it:
1f2389d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for colorScheme prop for
SplitHost. Color scheme will be propagated down the hierarchy.Closes https://github.com/issues/assigned?issue=software-mansion%7Creact-native-screens-labs%7C1026
Changes
colorSchemeprop toSplitHostcolorSchemeon iOS sidetest-split-color-schemeAfter - visual documentation
SplitHostColorScheme.mov
Test plan
Run
test-split-color-scheme.tsxChecklist