Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant call to DiagnosticsReporter::ensure #1604

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove redundant call to DiagnosticsReporter::ensure #1604

merged 1 commit into from
Sep 19, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Sep 18, 2024 •
edited
Loading

wawel37
wawel37 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No point to check for diagnostic errors twice :D

scarb/src/compiler/compilers/test.rs Show resolved Hide resolved
@maciektr maciektr added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 72b4984 Sep 19, 2024
22 checks passed
@maciektr maciektr deleted the maciektr/test-diag branch September 19, 2024 16:19
@BrewTestBot BrewTestBot mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawel37 wawel37 wawel37 approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciektr @wawel37