Update login API to v3, use DeriveGeneric, remove aeson-casing dependency#50
Merged
TristanCacqueray merged 1 commit intosoftwarefactory-project:masterfrom Mar 11, 2026
Merged
Conversation
aeson-casing dependency
aeson-casing dependencyDeriveGeneric, remove aeson-casing dependency
1a09dc7
into
softwarefactory-project:master
1 check passed
Contributor
|
Thanks, nice refactor too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR was primarily intended to bring login/logout API (https://spec.matrix.org/v1.17/client-server-api/#post_matrixclientv3login) up-to-date to v3.
As I was going to use GHC generics for
FromJson/ToJsoninstances I’ve also made the relevant fixes in the codebase to keep the usage of it consistent throughout the project.Full list of changes:
LoginResponseuses GHC generics for Aeson instancescamelTo2aesonOptions