Add otherParameters to ContentTypeRange, update MediaType#matches to take into account otherParameters.

[kamilkloch]

Fixes #305.

[adamw]

Could you also create a PR (relying on these changes) in tapir, so that we could review both together (it would necessarily use a locally-published model version)?

[kamilkloch]

I checked tapir locally against the locally published sttp-model. What do you mean by submitting this as a PR? It will not compile (missing locally published sttp-model).

[adamw]

I know, but some more changes are needed on the tapir side, no? :) I can then checkout both PRs locally & test

[kamilkloch]

I did not need to alter a single line in tapir to make it compile, I beileve it should work as expected with the new sttp-model. I tried to add some tests, but got lost in the tapir testing machinery :/ (ContentNegitiation, ServerContentNegotiationTests). I would appreciate your help here. Thank you!

[adamw]

ServerContentNegotiationTests is the right place to add a test :) If you add a test there, it will be ran when the tests for any specific interpreter's tests are run, e.g. NettyFutureServerTest.

The test itself consists of an endpoint (here you would need to create an endpoitn with the oneOf) and an sttp-client request to make (here you would need to include the appropriate header).

[kamilkloch]

@adamw please give it a spin: softwaremill/tapir#3243

[adamw]

Thanks for the work :)

[adamw]

1.7.3 should be out soon

[kamilkloch]

Once 1.7.3 lands in maven, shall I make a PR to tapir, with the bumped dependency and the added tests?

[adamw]

Yeah maybe simply update the PR that is already there with the test?