Add transaction send helpers #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prepareTransaction with compute - sendTransactionWithRetries
heyAyushh
requested changes
Jan 8, 2025
| * @property commitment - Desired commitment level for the transaction | ||
| * @property skipPreflight - Whether to skip transaction simulation | ||
| * @property onStatusUpdate - Callback function to receive transaction status updates |
src/lib/transaction.ts
Outdated
| @@ -52,6 +64,265 @@ export const getSimulationComputeUnits = async ( | |||
| sigVerify: false, | |||
| }); | |||
|
|
|||
| getErrorFromRPCResponse(rpcResponse); | |||
| if (rpcResponse.value.err) { | |||
There was a problem hiding this comment.
imo these should be wrapped in try catch block,
in instances where rpcResponse.value is undefined, it will throw an error and break.
for this specific error rpcResponse?.value?.err makes sense.
There was a problem hiding this comment.
That makes sense! Thanks, updated
heyAyushh
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have to write tons of boilerplate code to send transactions. This abstracts away most of it. Helping with simulating and setting compute budget and fee instructions and makes retry and confirmation easy.
Also better error handling which now shows the program logs when the simulation fails.