Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Lookup Table Course and Lab #479

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

devvspaces
Copy link

@devvspaces devvspaces commented Sep 12, 2024

Problem

The Versioned Transactions and Lookup Tables course has some grammatical errors also in the Lab and I found some deprecated code and incorrect code snippets.

Summary of Changes

Typos, grammatical errors, code snippets and repos, eliminated async wrappers

Fixes

  • Added keywords for SEO metadata
  • Use for notes, tips, warnings, and cautions
  • Avoided picking favorites by linking to solana.com/rpc instead of listing specific names
  • Added prerequisite installations where necessary
  • Fixed Unboxed Lesson and Solution
  • Fixed Typo
  • Fixed grammatical errors using Grammarly and Hemmingway

Unboxed PRs

Unboxed-Software/solana-versioned-transactions#2
Unboxed-Software/solana-versioned-transactions#3

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments about for the first few parts of this PR, please read them, make changes and then re-submit if you want to get this merged and win this lesson bounty.

content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
Copy link
Author

@devvspaces devvspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the issues and made appropriate updates to my PR on Unboxed

content/courses/program-optimization/lookup-tables.md Outdated Show resolved Hide resolved
Copy link
Author

@devvspaces devvspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved them all thanks @mikemaccana

@devvspaces
Copy link
Author

hi @mikemaccana i am done with the changes requested here

@mikemaccana
Copy link
Collaborator

Thanks @devvspaces ! While you didn't win this particular lesson, there's a lot of good stuff in this PR we'd still love to have your updates. Could you please rebase on top of current main?

Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above re: rebasing!

@devvspaces
Copy link
Author

@mikemaccana i will do that thanks

@devvspaces
Copy link
Author

Done that @mikemaccana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants