-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Lookup Table Course and Lab #479
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments about for the first few parts of this PR, please read them, make changes and then re-submit if you want to get this merged and win this lesson bounty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed the issues and made appropriate updates to my PR on Unboxed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved them all thanks @mikemaccana
hi @mikemaccana i am done with the changes requested here |
Thanks @devvspaces ! While you didn't win this particular lesson, there's a lot of good stuff in this PR we'd still love to have your updates. Could you please rebase on top of current main? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above re: rebasing!
@mikemaccana i will do that thanks |
Done that @mikemaccana |
Problem
The
Versioned Transactions and Lookup Tables
course has some grammatical errors also in the Lab and I found some deprecated code and incorrect code snippets.Summary of Changes
Typos, grammatical errors, code snippets and repos, eliminated async wrappers
Fixes
Unboxed PRs
Unboxed-Software/solana-versioned-transactions#2
Unboxed-Software/solana-versioned-transactions#3