fix(core): Fix metadata fields parsing#223
Merged
MicaiahReid merged 8 commits intomainfrom Jul 16, 2025
Merged
Conversation
…rialization - Introduced helper functions for converting transaction metadata to UI formats, enhancing code maintainability.
…rst_local_slot method
… match explorer expectations
MicaiahReid
requested changes
Jul 15, 2025
MicaiahReid
approved these changes
Jul 15, 2025
lgalabru
reviewed
Jul 15, 2025
| @@ -206,18 +206,25 @@ pub fn transform_tx_metadata_to_ui_accounts( | |||
| meta.inner_instructions | |||
Collaborator
There was a problem hiding this comment.
Should this method take ownership of meta and transform the data, instead of cloning?
So
pub fn transform_tx_metadata_to_ui_accounts(
meta: TransactionMetadata,
) and then use into_iter()
?
lgalabru
approved these changes
Jul 15, 2025
Collaborator
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Looking good, thanks @BretasArthur1 !
…ke ownership of transactionmetadata to avoid cloning and improving performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.