Merged
Conversation
Closed
lgalabru
approved these changes
Mar 31, 2026
Collaborator
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Looking great, thanks @MicaiahReid!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578
The new LiteSVM release adds a fix to automatically create feature accounts for activated features. This allows us to remove some hacky code paths where we were previously inserting these accounts manually.
This LiteSVM change also had some downstream changes - the
with_feature_setinitializer combined with thewith_feature_accountsinitializer makes the features active and creates the accounts. Then, later if we were to deactivate a feature, the feature account would still exist and appear active in some cases. This is normal behavior for the VM, but we were instantiating things in a weird order - first with all features, then stripping it down to mainnet features. This was causing some issues. So I've refactored how we initialize the VM - not setting feature accounts until we've got the actual list of feature sets ready.Finally, the LiteSVM release had some fixes around rent handling, specifically requiring the accurate minimum rent. This broke a bunch of our tests that were not leaving accounts with minimum rent. Those tests are fixed.