feat:added fetching address lookup accounts implementation#85
feat:added fetching address lookup accounts implementation#85MicaiahReid merged 3 commits intosolana-foundation:mainfrom
Conversation
MicaiahReid
left a comment
There was a problem hiding this comment.
This is awesome work, thank you @adpthegreat!!
Could you also take a look at this line and see if we can include the address table lookups: https://github.com/txtx/surfpool/blob/0888995b9a73e0d5d12320c7ed183279ebe936e2/crates/core/src/types.rs#L91
I think it should be similar to what you've already done, but perhaps keeping the alt accounts separated from the message accounts in this part: https://github.com/txtx/surfpool/blob/0888995b9a73e0d5d12320c7ed183279ebe936e2/crates/core/src/types.rs#L58-L79
|
|
||
| #[tokio::test] | ||
| async fn test_add_alt_fetching() { | ||
| let mock_tx = VersionedTransaction { |
There was a problem hiding this comment.
This is awesome! Could you add in a comment or something indicating what this transaction or doing, or how the instructions/account_keys/address_lookup_table was derived, cause this is quite the intimidating struct 😰
|
|
@MicaiahReid can we merge this PR? |
|
@lgalabru, not yet, I'd like to see the test working, but I'm also having trouble thinking of how to accomplish this. I can investigate tomorrow |
|
Great work @adpthegreat! I'll think on the tests and see what we can do, but we don't want to hold back the functionality any longer. |
Fixing tests (WIP), closes #84