Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to set ALICE_WEBID before running the tests #67

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mrvahedi68
Copy link
Collaborator

If we don't set ALICE_WEBID then storage related tests will fail.

Related Issue: nodeSolidServer/node-solid-server#1736

Copy link
Collaborator

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielbdejong michielbdejong merged commit 29d6eff into main Aug 25, 2023
@michielbdejong
Copy link
Collaborator

Actually, this is now diverging from how the run-against-nss script does it. Is that a conscious choice or an oversight?

https://github.com/solid-contrib/solid-crud-tests/blob/main/run-against-nss.sh#L7-L8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants