Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative SPARQL Update support #330

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

kjetilk
Copy link
Member

@kjetilk kjetilk commented Oct 21, 2021

During the Solid Editors call 2021-10-20,  @timbl reiterated that it might be a good idea to have different syntax for different semantics rather than the consensus of #125. I decided to explore this further, also in light of the discussion in #322 and this pull request can be thought of as an alternative to #320, but it also builds on it.

In this PR, I have replaced DELETE with REMOVE and so, REMOVE carries semantics that enables error reporting. This PR is actually more complete than #320, as the latter was intended to be a minimal change to SPARQL. This PR departs more significantly, but also defines a MIME Type for the result.

Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel comfortable supporting this idea, given that it means we cannot use an existing stack. As Solid, we should not reinvent the wheel, but rather leverage existing standards.

@kjetilk
Copy link
Member Author

kjetilk commented Oct 22, 2021

I appreciate this sentiment, but what we have to decide upon is how we define this in the short term that behaves approximately how it behaves in NSS (or where NSS can trivially be changed to it), i.e. for 0.9. I'm also trying to make sure we do not depart very far from SPARQL as defined, but the behavior in NSS is clearly not compatible with SPARQL, so in the short term, it is not an option to just leverage existing standards.

@RubenVerborgh
Copy link
Contributor

how we define this in the short term

In the short term, it's even harder to write a custom parser.

It's not just how fast NSS can change (which uses a custom, incomplete, non-compatible parser), but how all implementations can change (in particular those using an off-the-shelf standard SPARQL parser).

@kjetilk
Copy link
Member Author

kjetilk commented Oct 22, 2021

Sure. In #322 , I wrote a comment about what I personally think is reasonable to add and what is not.

In the code that I've seen, it doesn't seem like it is not so much the parser, it is more the semantics of connecting the counting of solutions to a failure. You might end up with a horrible hack using a thrown and caught exception, or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

Successfully merging this pull request may close these issues.

2 participants