Make ReactiveSet.clear() and ReactiveMap.clear() more efficient by only notifying listeners of existing members #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
webstrand
commented
Apr 2, 2025
| this.#triggers.dirty($KEYS); | ||
| for (const member of super.values()) { | ||
| this.#triggers.dirty(member); | ||
| } | ||
| super.clear(); |
There was a problem hiding this comment.
I did some benchmarking and did not see a performance hit to moving super.clear() into the batch operation. But if you like, I can save a snapshot prior to .clear() and iterate over that in batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listeners of non-existing members cannot observe different values before or after
.clear().get(nonexsting) -> undefinedor.has(nonexisting) -> falseso there's no use in notifying them.