Skip to content

fix: vite config types #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: vite config types #1856

wants to merge 3 commits into from

Conversation

huseeiin
Copy link
Contributor

now you'll get better type hints

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

now you'll get better type hints
Copy link

netlify bot commented Mar 18, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b50b600
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67dc6190ff8f9b0007bd6878
😎 Deploy Preview https://deploy-preview-1856--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: b50b600

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@huseeiin
Copy link
Contributor Author

this also adds extensions to output .d.ts files so that projects with moduleResolution: "nodenext" can consume @solidjs/start, this doesn't change solid's moduleResolution.

@birkskyum birkskyum changed the title fix vite config types fix: vite config types Mar 20, 2025
@birkskyum
Copy link
Member

birkskyum commented Mar 20, 2025

@atilafassina , is this Contrib CI check blocking because of the heseeiin:main is the main branch and not a feature branch? can we turn that piece of the check off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants