-
-
Notifications
You must be signed in to change notification settings - Fork 204
Add Suport symfony 8 and php 8.5 #1841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Conversation
|
hmmm any idea which approach I could use in this case: we are using : Symfony\Component\PropertyInfo\Type, But in Symfony 8 it was replaced to @dmaicher any idea? |
I guess we can just ignore those errors? |
b932696 to
0a4f209
Compare
now I get what you mean 😄 , getTypes is not used anymore. then yeah I guess we are safe to remove this method too. should I add deprecation trigger, or just |
79e1192 to
a8442ff
Compare
| "sonata-project/form-extensions": "^1.20 || ^2.0", | ||
| "sonata-project/seo-bundle": "^3.4", | ||
| "sonata-project/twig-extensions": "^1.3 || ^2.0", | ||
| "symfony-cmf/routing-bundle": "^2.1 || ^3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I strict on ^3.1.2 or keep it more flexible in ^3.0?
the problem detected was more related with symfony-cmf then page bundle.
Ignore errors from getTypes
a8442ff to
f15e252
Compare
| path: src/Form/Type/PageSelectorType.php | ||
|
|
||
| - | ||
| rawMessage: Possibly invalid array key type string|null. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know if it could be related with phpstan/phpstan-symfony#322
like we are doing on https://github.com/sonata-project/SonataPageBundle/blob/4.x/phpstan-baseline.neon#L22
But I would prefer ignore those errors besides add workaround for code that never going to be used. like this getType as null.
we add checks to verify if it's null or not, But it is a field that should be filled, otherwise some places wont work, like phpstan says.
if this field is null, the code will break for sure.
My suggestion is, ignore those errors and create a issue to solve this mess, it will make our life easier.
and I remember it was painful for this PR: #1522
let me know what you think and I could open a issue.
| @@ -1,24 +1,181 @@ | |||
| parameters: | |||
| ignoreErrors: | |||
| - # Disallow VariableMethodCallRule and VariablePropertyFetchRule | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I create another file to not mix with this one?
50ba66b to
2825101
Compare
2825101 to
fe6cd11
Compare
fe6cd11 to
2bc4fd3
Compare
Add Suport symfony 8 and php 8.5
I am targeting this branch, because {reason}.
Related: #1837
Changelog
To do