Add token decimal precision validation for contribution amounts#100
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Add token decimal precision validation for contribution amounts#100WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Conversation
Changes: - Query token decimals during group creation - Validate contribution_amount aligns with token's minimum unit - Store token_decimals in SavingsGroup metadata - Reject amounts that would cause rounding issues This ensures all contribution amounts are valid whole numbers of the token's smallest unit, preventing precision loss. Closes sorosave-protocol#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements input validation for contribution amounts to ensure they align with the token's decimal precision, as requested in #71.
Changes:
create_groupcontribution_amountis a whole number of the token's minimum unittoken_decimalsinSavingsGroupmetadata for future referenceHow it works:
The validation calculates the minimum token unit (
10^decimals) and checks that the contribution amount is evenly divisible by it. This prevents precision loss and ensures all contributions are valid.Example:
Closes #71