Add group description field with length validation#104
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Add group description field with length validation#104WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Conversation
Changes: - Add description: String field to SavingsGroup struct - Accept description parameter in create_group function - Enforce max length of 256 characters - Add DescriptionTooLong error variant - Return description in get_group response - Update all tests to include description parameter - Add test coverage for description validation This allows group creators to provide context about their savings group's purpose and rules. Closes sorosave-protocol#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a description field to savings groups, allowing creators to provide context about their group's purpose and rules, as requested in #50.
Changes:
description: Stringfield toSavingsGroupstructdescriptionparameter increate_groupfunctionDescriptionTooLongerror variant toContractErrorget_groupresponseUse cases:
Validation:
The 256-character limit ensures descriptions are concise while preventing storage bloat.
Closes #50