Add enhanced member join and leave events#105
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Add enhanced member join and leave events#105WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Conversation
Changes: - Emit mem_join event with (group_id, member, timestamp, member_count) - Emit mem_leave event with (group_id, member, timestamp, member_count) - Include member count after action for indexer tracking - Add test coverage for join/leave event flow These structured events enable indexers to track group membership changes over time and maintain accurate member count history. Closes sorosave-protocol#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds structured events for member join and leave actions to support indexer consumption, as requested in #53.
Changes:
mem_joinevent with(group_id, member_address, timestamp, member_count)mem_leaveevent with(group_id, member_address, timestamp, member_count)Why this matters:
These structured events enable indexers to:
Event structure:
group_id: Which group the action occurred inmember_address: Who joined or lefttimestamp: When the action happened (ledger timestamp)member_count: Total members after the actionCloses #53