Add maximum group duration limit#106
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Conversation
Changes: - Add MAX_GROUP_DURATION constant (365 days) - Validate total_rounds * cycle_length <= max_duration in start_group - Add DurationTooLong error variant - Return clear error if duration exceeds limit - Add test coverage for both valid and invalid durations This prevents groups from running indefinitely long savings cycles, ensuring reasonable timeframes for all participants. Closes sorosave-protocol#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enforces a maximum total duration for savings groups to prevent indefinitely long cycles, as requested in #55.
Changes:
MAX_GROUP_DURATIONconstant (365 days in seconds)total_rounds * cycle_length <= MAX_GROUP_DURATIONduringstart_groupDurationTooLongerror variant toContractErrorWhy this matters:
Without a duration limit, groups could theoretically run for years or decades, which:
Implementation:
The validation happens in
start_group(notcreate_group) becausetotal_roundsequals the final member count, which isn't known until the group starts.Example:
Closes #55