Add event for member join and leave actions#115
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Add event for member join and leave actions#115WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Conversation
Changes: - Emit mem_join event with (group_id, member, timestamp, member_count) - Emit mem_leave event with (group_id, member, timestamp, member_count) - Include member count after action in event data - Add test coverage for event emission These structured events enable indexers to track group membership changes over time for analytics and UI updates. Closes sorosave-protocol#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds structured events for member join and leave actions, as requested in #53.
Changes:
mem_joinevent with (group_id, member, timestamp, member_count)mem_leaveevent with (group_id, member, timestamp, member_count)Why this matters:
These events enable:
Event structure:
Test coverage:
mem_joinevent is emitted on joinmem_leaveevent is emitted on leaveCloses #53