Add contract test: group full scenario#118
Open
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Open
Add contract test: group full scenario#118WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
WuXieSec wants to merge 1 commit intosorosave-protocol:mainfrom
Conversation
Changes: - Test group with max_members=2 - Fill with 2 members - Attempt to add 3rd member - Verify GroupFull error - Add additional tests for at-capacity and not-full scenarios These tests ensure the max_members limit is properly enforced and the correct error is returned when full. Closes sorosave-protocol#27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the group full scenario, as requested in #27.
Changes:
max_members=2GroupFullerrorWhy this matters:
These tests ensure:
max_memberslimit is properly enforcedTest coverage:
GroupFullCloses #27