Skip to content

[irqbalance] Add plugin for the IRQ balancing daemon - #4425

Open
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:add-irqbalance-plugin
Open

[irqbalance] Add plugin for the IRQ balancing daemon#4425
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:add-irqbalance-plugin

Conversation

@suraj-cmd

Copy link
Copy Markdown
Contributor

irqbalance is installed by default on Fedora, RHEL, Debian and Ubuntu, but sos
has no plugin for it and no other plugin references it. Its configuration never
reaches an sosreport, which matters when interrupts are not landing on the CPUs
an administrator expects.

The unit reads two environment files:

EnvironmentFile=@pkgconfdir@/irqbalance.env
EnvironmentFile=-@usrconfdir@/irqbalance

configure.ac resolves those to $prefix/etc/default and
${sysconfdir}/default, so the effective path differs between distributions.
Both conventional locations are collected, along with any systemd drop-ins,
since IRQBALANCE_BANNED_CPUS, IRQBALANCE_BANNED_CPULIST and
IRQBALANCE_ARGS are set there.

irqbalance.h defines the runtime socket directory as /run/irqbalance,
matching RuntimeDirectory=irqbalance/ in the unit; a listing of it is taken
rather than the sockets themselves.

The daemon holds no credentials, so no forbidden paths are needed.

Paths and the unit's environment file handling are taken from upstream
(misc/irqbalance.service.in, configure.ac, irqbalance.h) rather than a
running system. Confirmation of which of /etc/sysconfig/irqbalance and
/etc/default/irqbalance each distribution actually ships would be welcome —
I have collected both rather than guess.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

irqbalance is installed by default on Fedora, RHEL, Debian and
Ubuntu, but sos has no plugin for it and no other plugin
references it. Its configuration never reaches an sosreport,
which matters when interrupts are not landing on the CPUs an
administrator expects.

The unit reads two environment files:

  EnvironmentFile=@pkgconfdir@/irqbalance.env
  EnvironmentFile=-@usrconfdir@/irqbalance

configure.ac resolves those to $prefix/etc/default and
${sysconfdir}/default, so the effective path differs between
distributions. Both conventional locations are collected, along
with any systemd drop-ins, since IRQBALANCE_BANNED_CPUS,
IRQBALANCE_BANNED_CPULIST and IRQBALANCE_ARGS are set there.

irqbalance.h defines the runtime socket directory as
/run/irqbalance, matching RuntimeDirectory=irqbalance/ in the
unit; a listing of it is taken rather than the sockets
themselves.

The daemon holds no credentials, so no forbidden paths are
needed.

Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4425
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4425
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant