[irqbalance] Add plugin for the IRQ balancing daemon - #4425
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
irqbalance is installed by default on Fedora, RHEL, Debian and
Ubuntu, but sos has no plugin for it and no other plugin
references it. Its configuration never reaches an sosreport,
which matters when interrupts are not landing on the CPUs an
administrator expects.
The unit reads two environment files:
EnvironmentFile=@pkgconfdir@/irqbalance.env
EnvironmentFile=-@usrconfdir@/irqbalance
configure.ac resolves those to $prefix/etc/default and
${sysconfdir}/default, so the effective path differs between
distributions. Both conventional locations are collected, along
with any systemd drop-ins, since IRQBALANCE_BANNED_CPUS,
IRQBALANCE_BANNED_CPULIST and IRQBALANCE_ARGS are set there.
irqbalance.h defines the runtime socket directory as
/run/irqbalance, matching RuntimeDirectory=irqbalance/ in the
unit; a listing of it is taken rather than the sockets
themselves.
The daemon holds no credentials, so no forbidden paths are
needed.
Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
1 similar comment
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
irqbalance is installed by default on Fedora, RHEL, Debian and Ubuntu, but sos
has no plugin for it and no other plugin references it. Its configuration never
reaches an sosreport, which matters when interrupts are not landing on the CPUs
an administrator expects.
The unit reads two environment files:
configure.acresolves those to$prefix/etc/defaultand${sysconfdir}/default, so the effective path differs between distributions.Both conventional locations are collected, along with any systemd drop-ins,
since
IRQBALANCE_BANNED_CPUS,IRQBALANCE_BANNED_CPULISTandIRQBALANCE_ARGSare set there.irqbalance.hdefines the runtime socket directory as/run/irqbalance,matching
RuntimeDirectory=irqbalance/in the unit; a listing of it is takenrather than the sockets themselves.
The daemon holds no credentials, so no forbidden paths are needed.
Paths and the unit's environment file handling are taken from upstream
(
misc/irqbalance.service.in,configure.ac,irqbalance.h) rather than arunning system. Confirmation of which of
/etc/sysconfig/irqbalanceand/etc/default/irqbalanceeach distribution actually ships would be welcome —I have collected both rather than guess.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines