Skip to content

[lldpd] Add plugin for the LLDP daemon - #4428

Open
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:add-lldpd-plugin
Open

[lldpd] Add plugin for the LLDP daemon#4428
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:add-lldpd-plugin

Conversation

@suraj-cmd

Copy link
Copy Markdown
Contributor

lldpd is packaged for Fedora, RHEL via EPEL, Debian and Ubuntu, but sos has no
plugin for it. networking.py collects /var/lib/lldpad/, which belongs to
lldpad, a separate implementation; nothing in the tree covers lldpd itself.

Paths are taken from upstream. src/daemon/lldpd.c passes
SYSCONFDIR "/lldpd.conf" and SYSCONFDIR "/lldpd.d" on resume, and
src/daemon/lldpd.service.in sources both /etc/default/lldpd and
/etc/sysconfig/lldpd as optional environment files, so both are collected
rather than assuming which one a distribution ships.

The lldpcli subcommands are those registered in src/client/show.c.
show neighbors details is the useful one for support: it records which switch
and port each interface is attached to, which cannot otherwise be recovered
from an sosreport.

The daemon holds no credentials, so no forbidden paths are needed.

Worth noting networking.py already collects /var/lib/lldpad/ for the
separate lldpad implementation — this plugin does not overlap with it, but a
reviewer may prefer the two be reconciled.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs

lldpd is packaged for Fedora, RHEL via EPEL, Debian and Ubuntu,
but sos has no plugin for it. networking.py collects
/var/lib/lldpad/, which belongs to lldpad, a separate
implementation; nothing in the tree covers lldpd itself.

Paths are taken from upstream. src/daemon/lldpd.c passes
SYSCONFDIR "/lldpd.conf" and SYSCONFDIR "/lldpd.d" on resume,
and src/daemon/lldpd.service.in sources both
/etc/default/lldpd and /etc/sysconfig/lldpd as optional
environment files, so both are collected rather than assuming
which one a distribution ships.

The lldpcli subcommands are those registered in
src/client/show.c. "show neighbors details" is the useful one
for support: it records which switch and port each interface is
attached to, which cannot otherwise be recovered from an
sosreport.

The daemon holds no credentials, so no forbidden paths are
needed.

Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4428
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant