[lldpd] Add plugin for the LLDP daemon - #4428
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
lldpd is packaged for Fedora, RHEL via EPEL, Debian and Ubuntu, but sos has no plugin for it. networking.py collects /var/lib/lldpad/, which belongs to lldpad, a separate implementation; nothing in the tree covers lldpd itself. Paths are taken from upstream. src/daemon/lldpd.c passes SYSCONFDIR "/lldpd.conf" and SYSCONFDIR "/lldpd.d" on resume, and src/daemon/lldpd.service.in sources both /etc/default/lldpd and /etc/sysconfig/lldpd as optional environment files, so both are collected rather than assuming which one a distribution ships. The lldpcli subcommands are those registered in src/client/show.c. "show neighbors details" is the useful one for support: it records which switch and port each interface is attached to, which cannot otherwise be recovered from an sosreport. The daemon holds no credentials, so no forbidden paths are needed. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lldpd is packaged for Fedora, RHEL via EPEL, Debian and Ubuntu, but sos has no
plugin for it.
networking.pycollects/var/lib/lldpad/, which belongs tolldpad, a separate implementation; nothing in the tree covers lldpd itself.
Paths are taken from upstream.
src/daemon/lldpd.cpassesSYSCONFDIR "/lldpd.conf"andSYSCONFDIR "/lldpd.d"on resume, andsrc/daemon/lldpd.service.insources both/etc/default/lldpdand/etc/sysconfig/lldpdas optional environment files, so both are collectedrather than assuming which one a distribution ships.
The lldpcli subcommands are those registered in
src/client/show.c.show neighbors detailsis the useful one for support: it records which switchand port each interface is attached to, which cannot otherwise be recovered
from an sosreport.
The daemon holds no credentials, so no forbidden paths are needed.
Worth noting
networking.pyalready collects/var/lib/lldpad/for theseparate lldpad implementation — this plugin does not overlap with it, but a
reviewer may prefer the two be reconciled.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines