Skip to content

[networkmanager] Declare NetworkManager in the services tuple - #4438

Open
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:networkmanager-services-tuple
Open

[networkmanager] Declare NetworkManager in the services tuple#4438
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:networkmanager-services-tuple

Conversation

@suraj-cmd

Copy link
Copy Markdown
Contributor

setup() calls add_journal() for the NetworkManager unit but the plugin
declares no services tuple and never collects the service status. An
sosreport from a host with a networking problem therefore contains the journal
but nothing showing whether the daemon is enabled, running, or failing to
start.

Plugin._collect_services() runs each entry of the tuple through
is_service() and calls both add_service_status() and add_journal(), so
declaring the unit adds the missing status and replaces the explicit call.

It also gives the plugin an enablement trigger beyond the package name. The
package differs between distributions — NetworkManager on Red Hat,
network-manager on Debian and Ubuntu — while the unit is NetworkManager on
both.

Follows @TurboTurtle's review comment on #4429, and the same change made in
#4436 and #4437.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

setup() calls add_journal() for the NetworkManager unit but the
plugin declares no services tuple and never collects the service
status. An sosreport from a host with a networking problem
therefore contains the journal but nothing showing whether the
daemon is enabled, running, or failing to start.

Plugin._collect_services() runs each entry of the tuple through
is_service() and calls both add_service_status() and
add_journal(), so declaring the unit adds the missing status and
replaces the explicit call.

It also gives the plugin an enablement trigger beyond the
package name. The package differs between distributions -
NetworkManager on Red Hat, network-manager on Debian and Ubuntu
- while the unit is NetworkManager on both.

Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
@suraj-cmd

Copy link
Copy Markdown
Contributor Author

Tested on RHEL 10 (aarch64), NetworkManager running as shipped.

Before, on main:

# ls /var/tmp/sosreport-localhost-2026-08-11-kjirjnz/sos_commands/networkmanager/
journalctl_--no-pager_--unit_NetworkManager
NetworkManager_--print-config
nmcli_con
nmcli_con_show_--active
nmcli_con_show_id_enp0s1
nmcli_con_show_id_lo
nmcli_dev
nmcli_dev_show_enp0s1
nmcli_dev_show_lo
nmcli_-f_all_con
nmcli_general_status

After, with this change:

# ls /var/tmp/sosreport-localhost-2026-08-11-gzzpsyy/sos_commands/networkmanager/
journalctl_--no-pager_--unit_NetworkManager
NetworkManager_--print-config
nmcli_con
nmcli_con_show_--active
nmcli_con_show_id_enp0s1
nmcli_con_show_id_lo
nmcli_dev
nmcli_dev_show_enp0s1
nmcli_dev_show_lo
nmcli_-f_all_con
nmcli_general_status
systemctl_status_NetworkManager

The journal is still collected, now via the services tuple rather than the
explicit call; the service status is new.

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4438
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant