[networkmanager] Declare NetworkManager in the services tuple - #4438
Open
suraj-cmd wants to merge 1 commit into
Open
[networkmanager] Declare NetworkManager in the services tuple#4438suraj-cmd wants to merge 1 commit into
suraj-cmd wants to merge 1 commit into
Conversation
setup() calls add_journal() for the NetworkManager unit but the plugin declares no services tuple and never collects the service status. An sosreport from a host with a networking problem therefore contains the journal but nothing showing whether the daemon is enabled, running, or failing to start. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the unit adds the missing status and replaces the explicit call. It also gives the plugin an enablement trigger beyond the package name. The package differs between distributions - NetworkManager on Red Hat, network-manager on Debian and Ubuntu - while the unit is NetworkManager on both. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
Contributor
Author
|
Tested on RHEL 10 (aarch64), NetworkManager running as shipped. Before, on main: After, with this change: The journal is still collected, now via the services tuple rather than the |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup()callsadd_journal()for the NetworkManager unit but the plugindeclares no
servicestuple and never collects the service status. Ansosreport from a host with a networking problem therefore contains the journal
but nothing showing whether the daemon is enabled, running, or failing to
start.
Plugin._collect_services()runs each entry of the tuple throughis_service()and calls bothadd_service_status()andadd_journal(), sodeclaring the unit adds the missing status and replaces the explicit call.
It also gives the plugin an enablement trigger beyond the package name. The
package differs between distributions —
NetworkManageron Red Hat,network-manageron Debian and Ubuntu — while the unit isNetworkManageronboth.
Follows @TurboTurtle's review comment on #4429, and the same change made in
#4436 and #4437.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines