[man] Document usernames and treat-certificates for sos clean - #4440
Open
suraj-cmd wants to merge 1 commit into
Open
[man] Document usernames and treat-certificates for sos clean#4440suraj-cmd wants to merge 1 commit into
suraj-cmd wants to merge 1 commit into
Conversation
suraj-cmd
force-pushed
the
man-document-clean-options
branch
from
August 10, 2026 19:12
0835c68 to
9da3d3b
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
pmoravec
approved these changes
Aug 11, 2026
pmoravec
added
Reviewed/Needs 2nd Ack
pmoravec
reviewed
Aug 11, 2026
Comment on lines
11
to
14
| [\-\-usernames] | ||
| [\-\-treat-certificates] | ||
| [\-\-map-file] | ||
| [\-\-jobs] |
Contributor
There was a problem hiding this comment.
A nitpick (like in the previous PR, when we are doing a change..): can you please add here -j short variant of the --jobs as well? My eyes spotted it is missing here as well..
Contributor
Author
There was a problem hiding this comment.
@pmoravec oops i missed that let me fix that in one min please stay with me
Contributor
Author
There was a problem hiding this comment.
@pmoravec its done now !!! can we gohead and merge ?
sos clean accepts --usernames and --treat-certificates but neither is documented in sos-clean.1, sos-mask.1 or sos-report.1, so there is no man page reference for either. --treat-certificates in particular decides whether certificate files found in an archive are obfuscated, kept, or removed before that archive is passed to a third party, which is a decision users should be able to find documented. Add both to the synopsis and the option list, alongside the other obfuscation inputs. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
suraj-cmd
force-pushed
the
man-document-clean-options
branch
from
August 11, 2026 10:10
9da3d3b to
56d8925
Compare
Contributor
|
ACK from me, let wait for 2nd approval to let us merge. Thanks for the PR and nitpick fix. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sos cleanaccepts--usernamesand--treat-certificatesbut neither isdocumented in
sos-clean.1,sos-mask.1orsos-report.1, so there is no manpage reference for either.
--treat-certificatesin particular decides whether certificate files found inan archive are obfuscated, kept, or removed before that archive is passed to a
third party, which is a decision users should be able to find documented.
This adds both to the synopsis and the option list, alongside the other
obfuscation inputs.
Follows the same gap found in #4430, where the S3 upload options were missing
from sos-report.1.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines