[ovn_central,ovn_host] Declare the OVN units in the services tuple - #4453
Open
suraj-cmd wants to merge 1 commit into
Open
[ovn_central,ovn_host] Declare the OVN units in the services tuple#4453suraj-cmd wants to merge 1 commit into
suraj-cmd wants to merge 1 commit into
Conversation
Both plugins call add_journal() for their unit - ovn-northd and ovn-controller respectively - but neither declares a services tuple, and neither collects the service status. An sosreport from a host where the daemon has failed to start therefore has the journal but nothing showing whether the unit is loaded, enabled or running. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the unit adds the missing status and replaces the explicit call. It also gives both plugins an enablement trigger beyond the package name, which matters here because they are written for deployments where OVN runs in containers: the package names differ between distributions and are frequently absent on a containerised host, while the unit name is the same. The tuples are declared on the shared base classes so they apply to both distribution subclasses. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both plugins call
add_journal()for their unit —ovn-northdandovn-controllerrespectively — but neither declares aservicestuple, andneither collects the service status. An sosreport from a host where the daemon
has failed to start therefore has the journal but nothing showing whether the
unit is loaded, enabled or running.
Plugin._collect_services()runs each entry of the tuple throughis_service()and calls bothadd_service_status()andadd_journal(), sodeclaring the unit adds the missing status and replaces the explicit call.
It also gives both plugins an enablement trigger beyond the package name, which
matters here because they are written for deployments where OVN runs in
containers: the package names differ between distributions and are frequently
absent on a containerised host, while the unit name is the same.
The tuples are declared on the shared base classes so they apply to both
distribution subclasses.
Companion to #4439, which made the same change for openvswitch. Both plugins
are grouped in one PR since they are the two halves of the same stack and the
change is identical.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines