Skip to content

[ovn_central,ovn_host] Declare the OVN units in the services tuple - #4453

Open
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:ovn-services-tuple
Open

[ovn_central,ovn_host] Declare the OVN units in the services tuple#4453
suraj-cmd wants to merge 1 commit into
sosreport:mainfrom
suraj-cmd:ovn-services-tuple

Conversation

@suraj-cmd

Copy link
Copy Markdown
Contributor

Both plugins call add_journal() for their unit — ovn-northd and
ovn-controller respectively — but neither declares a services tuple, and
neither collects the service status. An sosreport from a host where the daemon
has failed to start therefore has the journal but nothing showing whether the
unit is loaded, enabled or running.

Plugin._collect_services() runs each entry of the tuple through
is_service() and calls both add_service_status() and add_journal(), so
declaring the unit adds the missing status and replaces the explicit call.

It also gives both plugins an enablement trigger beyond the package name, which
matters here because they are written for deployments where OVN runs in
containers: the package names differ between distributions and are frequently
absent on a containerised host, while the unit name is the same.

The tuples are declared on the shared base classes so they apply to both
distribution subclasses.

Companion to #4439, which made the same change for openvswitch. Both plugins
are grouped in one PR since they are the two halves of the same stack and the
change is identical.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Both plugins call add_journal() for their unit - ovn-northd and
ovn-controller respectively - but neither declares a services
tuple, and neither collects the service status. An sosreport
from a host where the daemon has failed to start therefore has
the journal but nothing showing whether the unit is loaded,
enabled or running.

Plugin._collect_services() runs each entry of the tuple through
is_service() and calls both add_service_status() and
add_journal(), so declaring the unit adds the missing status and
replaces the explicit call.

It also gives both plugins an enablement trigger beyond the
package name, which matters here because they are written for
deployments where OVN runs in containers: the package names
differ between distributions and are frequently absent on a
containerised host, while the unit name is the same.

The tuples are declared on the shared base classes so they apply
to both distribution subclasses.

Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4453
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant