Skip to content

Handle some uncaught exceptions in explain mode #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yonatan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle some uncaught exceptions in explain mode #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af83033
Avoid some explain mode crashes on user errors (mismatched argument t…
yonatan Apr 11, 2025
a83d2b5
Explain mode: wrap a try..catch around an stoi() called with user input
yonatan Apr 11, 2025
8cd7e04
fix whitespace w/clang-format
yonatan Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 37 additions & 20 deletions src/include/souffle/provenance/Explain.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,13 @@ class Explain {
return true;
}
query = parseTuple(command[1]);
printTree(prov.explain(query.first, query.second, ExplainConfig::getExplainConfig().depthLimit));
try {
printTree(prov.explain(
query.first, query.second, ExplainConfig::getExplainConfig().depthLimit));
} catch (const ValueReadException& e) {
printError(tfm::format("%s\n", e.what()));
return true;
}
} else if (command[0] == "subproof") {
std::pair<std::string, std::vector<std::string>> query;
int label = -1;
Expand Down Expand Up @@ -144,29 +150,40 @@ class Explain {
printInfo(rules);

printPrompt("Pick a rule number: ");

std::string ruleNum = getInput();
auto variables = prov.explainNegationGetVariables(query.first, query.second, std::stoi(ruleNum));

// @ and @non_matching are special sentinel values returned by ExplainProvenance
if (variables.size() == 1 && variables[0] == "@") {
printInfo("The tuple exists, cannot explain negation of it!\n");
return true;
} else if (variables.size() == 1 && variables[0] == "@non_matching") {
printInfo("The variable bindings don't match, cannot explain!\n");
return true;
} else if (variables.size() == 1 && variables[0] == "@fact") {
printInfo("The rule is a fact!\n");
int ruleNum = 0;
try {
ruleNum = stoi(getInput());
} catch (std::exception& e) {
printError("Invalid rule number\n");
return true;
}

std::map<std::string, std::string> varValues;
for (auto var : variables) {
printPrompt("Pick a value for " + var + ": ");
varValues[var] = getInput();
}
try {
auto variables = prov.explainNegationGetVariables(query.first, query.second, ruleNum);

// @ and @non_matching are special sentinel values returned by ExplainProvenance
if (variables.size() == 1 && variables[0] == "@") {
printInfo("The tuple exists, cannot explain negation of it!\n");
return true;
} else if (variables.size() == 1 && variables[0] == "@non_matching") {
printInfo("The variable bindings don't match, cannot explain!\n");
return true;
} else if (variables.size() == 1 && variables[0] == "@fact") {
printInfo("The rule is a fact!\n");
return true;
}

std::map<std::string, std::string> varValues;
for (auto var : variables) {
printPrompt("Pick a value for " + var + ": ");
varValues[var] = getInput();
}

printTree(prov.explainNegation(query.first, std::stoi(ruleNum), query.second, varValues));
printTree(prov.explainNegation(query.first, ruleNum, query.second, varValues));
} catch (const ValueReadException& e) {
printError(tfm::format("%s\n", e.what()));
return true;
}
} else if (command[0] == "rule" && command.size() == 2) {
auto query = split(command[1], ' ');
if (query.size() != 2) {
Expand Down
29 changes: 20 additions & 9 deletions src/include/souffle/provenance/ExplainProvenance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@
namespace souffle {
class TreeNode;

class ValueReadException : public std::runtime_error {
public:
ValueReadException(const std::string& what_arg) : std::runtime_error(what_arg) {}
};

/** Equivalence class for variables in query command */
class Equivalence {
public:
Expand Down Expand Up @@ -240,15 +245,21 @@ class ExplainProvenance {
}

RamDomain valueRead(const char type, const std::string& value) const {
switch (type) {
case 'i': return ramBitCast(RamSignedFromString(value));
case 'u': return ramBitCast(RamUnsignedFromString(value));
case 'f': return ramBitCast(RamFloatFromString(value));
case 's':
assert(2 <= value.size() && value[0] == '"' && value.back() == '"');
return symTable.encode(value.substr(1, value.size() - 2));
case 'r': fatal("not implemented");
default: fatal("unhandled type attr code");
try {
switch (type) {
case 'i': return ramBitCast(RamSignedFromString(value));
case 'u': return ramBitCast(RamUnsignedFromString(value));
case 'f': return ramBitCast(RamFloatFromString(value));
case 's':
assert(2 <= value.size() && value[0] == '"' && value.back() == '"');
return symTable.encode(value.substr(1, value.size() - 2));
case 'r': fatal("not implemented");
default: fatal("unhandled type attr code");
}
} catch (const std::invalid_argument& e) {
throw ValueReadException(tfm::format("Invalid argument %s for type '%c'", value, type));
} catch (const std::out_of_range& e) {
throw ValueReadException(tfm::format("Out of range value %s for type '%c'", value, type));
}
}
};
Expand Down
Loading