Skip to content

Conversation

@Codechicken
Copy link

This small change cuts the amount of database metadata in half.
See the SQLite page for other benefits.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (89f2abe) to head (a7ac2c6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/include/souffle/io/WriteStreamSQLite.h 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
- Coverage   81.19%   81.17%   -0.03%     
==========================================
  Files         492      492              
  Lines       31001    31010       +9     
==========================================
+ Hits        25170    25171       +1     
- Misses       5831     5839       +8     
Files with missing lines Coverage Δ
src/include/souffle/io/WriteStreamSQLite.h 67.83% <80.00%> (+0.55%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quentin
Copy link
Member

quentin commented Dec 10, 2025

Hi, thanks for your interest in improving Soufflé.

I understand that WITHOUT ROWID may improve the database size, on the other hand this page https://sqlite.org/withoutrowid.html has a list of Differences From Ordinary Rowid Tables, some of which may not be desirable by default.

It would make more sense if the tables are made without rowid on user's request. For instance it can be a new attribute rowid=with|without of .output relation (IO=sqlite, rowid=with|without).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants