Open
Conversation
//if ($resource_permissions !== 0) $role_passed = count($action);
8:26
this line in each section seem to just break the thing
8:26
so i commented out
8:27
and
8:27
if ($permission->action == 'all' && in_array($permission->resource, $resource) /*&& $permission->item_id === $resource_id*/) {
8:27
seems that our permission checkboxes is not up to date with this code
8:28
we only give permission for page type but when the permission is requested it has a resource_id but our permission does not
8:28
so we need to bypass that line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//if ($resource_permissions !== 0) $role_passed = count($action);this line in each section seem to just break the thing
so i commented out
and
if ($permission->action == 'all' && in_array($permission->resource, $resource) /*&& $permission->item_id === $resource_id*/) {seems that our permission checkboxes is not up to date with this code
we only give permission for page type but when the permission is requested it has a resource_id but our permission does not
so we need to bypass that line