-
Notifications
You must be signed in to change notification settings - Fork 53
Added Exam mode #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Exam mode #1236
Conversation
…ar course under exam mode
…any of a user's courses
…for addition of enable_exam_mode and is_official_course to courses table
…ents circumventing force redirection to official course under exam mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need isOfficialCourse
anymore, right?
…ted unused IO.puts
… bypassing overlay by refreshing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing tests, thanks!
…cted object. fixed migrations
@@ -21,6 +21,7 @@ defmodule Cadet.Accounts.User do | |||
field(:provider, :string) | |||
field(:super_admin, :boolean) | |||
field(:email, :string) | |||
field(:is_paused, :boolean) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this is linked to the user and not their course_registration? Isn't exam mode related to their course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I thought linking this to the user would allow for the enforcing of the pause beyond the course so that if a user is paused due to opening other app / using dev tool (which is our plan), the user will have to settle the problem with the course admin / coordinator. But, now that you pointed out, maybe this should not affect the user through all their courses. Should I move this course_registration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichDom2185 thoughts?
One more thing which just came to mind. Correct me if I am wrong, your current implementation places all users with a course which has exam mode enabled have their SA placed on some sort of "lock down". Wouldn't this limit the use for admins/staff during the time in which the course is on lock down? |
@GabrielCWT |
…o separate private functions for readability.
…_controller; fixed a typing error in send_resp
…ned; improved readibility for pause_user
…ned; improved readibility for pause_user
…es returned; improved readibility for pause_user" This reverts commit 31bbf5a.
…changeset, and applied it in the focus logging controlelr
…ation on creation of new course; rejects all course config update with empty resume code regardless of exam mode state
…de resume_code a required field
…ficial_course, and resume_code
Description
01/04/25
09/04/25
Note: this may require change to the DB diagram in README.md
Type of Change
Checklist