Skip to content

Remove sourcecast and sourcereel#1361

Draft
RichDom2185 wants to merge 2 commits into
masterfrom
remove-sourcecast-sourcereel
Draft

Remove sourcecast and sourcereel#1361
RichDom2185 wants to merge 2 commits into
masterfrom
remove-sourcecast-sourcereel

Conversation

@RichDom2185

@RichDom2185 RichDom2185 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Unused features, to be deleted to focus on core features

@RichDom2185 RichDom2185 self-assigned this Jul 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Sourcecast feature entirely from the application, including its database schema, configuration, S3 bucket resources, IAM policies, controllers, views, routes, and associated tests. However, a critical issue was identified in test/cadet/courses/courses_test.exs, where leftover references to enable_sourcecast and a remaining describe Sourcecast block will cause compilation and test failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

alias Cadet.{Courses, Repo}
alias Cadet.Accounts.{CourseRegistration, User}
alias Cadet.Courses.{Course, Group, Sourcecast, SourcecastUpload}
alias Cadet.Courses.{Course, Group}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Although Sourcecast and SourcecastUpload have been removed from the aliases, there are still several references to enable_sourcecast and a whole describe "Sourcecast" block remaining in this test file.\n\nSpecifically:\n- enable_sourcecast is still used in the parameters and assertions of describe "create course config", describe "get course config", and describe "update course config" (e.g., lines 26, 62, 89, 99, 117, 129, 147).\n- The entire describe "Sourcecast" block (lines 553-583) remains at the end of the file and references the deleted Sourcecast and SourcecastUpload modules, as well as the deleted Courses.upload_sourcecast_file and Courses.delete_sourcecast_file functions.\n\nThese leftover references will cause compilation and test failures. Please clean up all remaining references to Sourcecast, SourcecastUpload, and enable_sourcecast in this file.

@coveralls

coveralls commented Jul 3, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 87.422%remove-sourcecast-sourcereel into master. No base build found for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants