Add payload size limit #3017
Merged
Add payload size limit #3017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding BE PR: source-academy/backend#1151 |
Pull Request Test Coverage Report for Build 14175086497Details
💛 - Coveralls |
RichDom2185
requested changes
Aug 12, 2024
Comment on lines
25
to
28
| const MESSAGE_TOO_LONG_MESSAGE: Readonly<ChatMessage> = { | ||
| content: 'Your message is too long. Please try again with a shorter message.', | ||
| role: 'assistant' | ||
| }; |
There was a problem hiding this comment.
That way, this will never be necessary. From UX perspective, it's easier for the user to edit their message before sending in order to fit the character limit, as opposed to having to copy and paste their previous message and send it again. Not to mention, if you do it like this, there will be a mismatch between the conversation history stored in the FE state with the one stored in the DB
There was a problem hiding this comment.
You are right;
it is more intuitive to do let the user trigger this in the first place;
this also pollute the chat history, making it less readable.
|
@RichDom2185 Could you review this again. Is it ready for merge? |
RichDom2185
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How to test
Checklist