Skip to content

Migrate CSE machine side content to functional components #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Migrate CSE machine side content to functional components #3305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
804336e
Migrate CSE side content to FC
RichDom2185 Aug 15, 2025
199cb5e
Add memoization hooks
RichDom2185 Aug 15, 2025
64adc3c
Remove addressed TODO
RichDom2185 Aug 15, 2025
f092255
Remove unused state
RichDom2185 Aug 15, 2025
ee4c5ee
Destructure dispatch props
RichDom2185 Aug 15, 2025
bdc8db1
Remove `editorWidth` from side content
RichDom2185 Aug 15, 2025
83506a9
Remove `editorWidth` from CSE side content
RichDom2185 Aug 15, 2025
20bb516
Remove unused state
RichDom2185 Aug 15, 2025
f2aad8e
Reorder effect
RichDom2185 Aug 15, 2025
a8b0a50
Refactor default text to separate component
RichDom2185 Aug 15, 2025
c8a9050
Merge branch 'master' into cse-fc
martin-henz Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/commons/sideContent/SideContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import type {

export type SideContentProps = {
renderActiveTabPanelOnly?: boolean;
editorWidth?: string;
tabs?: {
beforeDynamicTabs: SideContentTab[];
afterDynamicTabs: SideContentTab[];
Expand All @@ -27,7 +26,6 @@ const renderTab = (
tab: SideContentTab,
shouldAlert: boolean,
workspaceLocation?: SideContentLocation,
editorWidth?: string,
sideContentHeight?: number
) => {
const iconSize = 20;
Expand Down Expand Up @@ -56,7 +54,6 @@ const renderTab = (
props: {
...tab.body.props,
workspaceLocation,
editorWidth,
sideContentHeight
}
}
Expand All @@ -66,7 +63,7 @@ const renderTab = (
return <Tab key={tabId} {...tabProps} panel={tabPanel} />;
};

const SideContent = ({ renderActiveTabPanelOnly, editorWidth, ...props }: SideContentProps) => (
const SideContent = ({ renderActiveTabPanelOnly, ...props }: SideContentProps) => (
<SideContentProvider {...props}>
{({ tabs: allTabs, alerts: tabAlerts, changeTabsCallback, selectedTab, height }) => (
<div className="side-content">
Expand All @@ -80,13 +77,7 @@ const SideContent = ({ renderActiveTabPanelOnly, editorWidth, ...props }: SideCo
>
{allTabs.map(tab => {
const tabId = getTabId(tab);
return renderTab(
tab,
tabAlerts.includes(tabId),
props.workspaceLocation,
editorWidth,
height
);
return renderTab(tab, tabAlerts.includes(tabId), props.workspaceLocation, height);
})}
</Tabs>
</div>
Expand Down
Loading