Skip to content

Rewrite: Stepper #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

Rewrite: Stepper #1742

wants to merge 81 commits into from

Conversation

kavishsathia
Copy link

@kavishsathia kavishsathia commented Feb 28, 2025 •
edited by monnss69
Loading

Description

This PR aims to rewrite the stepper. The implementation is still in progress.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Feb 28, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13645552196

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.126%
Totals Coverage Status
Change from base Build 13624411860: 0.0%
Covered Lines: 10762
Relevant Lines: 12898
💛 - Coveralls

@martin-henz martin-henz marked this pull request as draft February 28, 2025 09:05
CATISNOTSODIUM and others added 24 commits March 8, 2025 10:53
@CATISNOTSODIUM
Merge branch 'rewrite/stepper' of https://github.com/source-academy/j…
c67c36f 
…s-slang into rewrite/stepper
@CATISNOTSODIUM
add program, statements, and variable declaration handler
0b93acd
@CATISNOTSODIUM
restructure project, add substitution
e32d110
@CATISNOTSODIUM
(feat) block scope handling
cc125fa
@CATISNOTSODIUM
(feat) adding freeName
e86cf6a
@martin-henz
Merge branch 'master' into rewrite/stepper
496160b
@CATISNOTSODIUM
(feat) add alpha renaming
fe6ecbc
@CATISNOTSODIUM
Merge branch 'rewrite/stepper' of https://github.com/source-academy/j…
00aa05f 
…s-slang into rewrite/stepper
@CATISNOTSODIUM
(fix) alpha renaming for multiple variables
873bfee
@CATISNOTSODIUM
(fix) edit source runner for stepper
9210965
@kavishsathia
Feat: Add IfStatements
34736ee
@kavishsathia
Feat: Add ConditionalExpressions
355a65a
@kavishsathia
Feat: Add ArrowFunctionExpressions and FunctionApplications
819fae7
@CATISNOTSODIUM
(feat) add explanation handler
b09fb3d
@kavishsathia
Feat: ArrowFunctions with BlockStatement bodies
20961b3
@kavishsathia
Feat: Add MuTerms v1
52ad7ef
@kavishsathia
Feat: Add Alpha Renaming for Arrow Functions v1
89d4290
@CATISNOTSODIUM
(feat) add explanation handler
003f193
@CATISNOTSODIUM
Merge branch 'rewrite/stepper' of https://github.com/source-academy/j…
00d8cfb 
…s-slang into rewrite/stepper
@kavishsathia
Feat: Add Alpha-renaming for ArrowFunctionExpressions
c907c83
@kavishsathia
Fix: Remove ReturnStatements
c3aa835
@kavishsathia
Feat: Add BlockExpressions
d556243
@kavishsathia
Feat: Add FunctionDeclarations
58bb457
@kavishsathia
Fix: Modify ReturnStatement Contraction Logic
5aac4dc
@CATISNOTSODIUM CATISNOTSODIUM mentioned this pull request Apr 8, 2025
Draft
7 tasks
@martin-henz martin-henz marked this pull request as ready for review April 29, 2025 08:50
@martin-henz martin-henz marked this pull request as draft April 29, 2025 08:53
@CATISNOTSODIUM CATISNOTSODIUM marked this pull request as ready for review May 7, 2025 12:32
@CATISNOTSODIUM
Copy link
Member

This branch is ready for review.

monnss69
monnss69 requested changes May 9, 2025
View reviewed changes
Copy link

@monnss69 monnss69 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

monnss69
monnss69 approved these changes May 9, 2025
View reviewed changes
Copy link

@monnss69 monnss69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RichDom2185
Copy link
Member

LGTM!

Some tests still seem to be failing? Can you double check if they're okay?

@CATISNOTSODIUM
Copy link
Member

CATISNOTSODIUM commented May 11, 2025 •
edited
Loading

LGTM!

Some tests still seem to be failing? Can you double check if they're okay?

Can you specify which cases are failing?
Is it from the tracer_full.ts or other files?

Based on the current CI/CD, it's seem like the error comes from src/tests/index.ts.

@RichDom2185
Copy link
Member

RichDom2185 commented May 11, 2025 •
edited
Loading

LGTM!

Some tests still seem to be failing? Can you double check if they're okay?

Can you specify which cases are failing?

Is it from the tracer_full.ts or other files?

Based on the current CI/CD, it's seem like the error comes from src/tests/index.ts.

You can look at the logs in the CI: https://github.com/source-academy/js-slang/actions/runs/14953607972/job/42006258517

So yes it is from the index file. Any idea why it's failing?

@CATISNOTSODIUM
Copy link
Member

I'm not sure if it's the CI/CD problem or not.
By the way, is this problem occurs on other PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz left review comments

@CATISNOTSODIUM CATISNOTSODIUM CATISNOTSODIUM left review comments

@monnss69 monnss69 monnss69 approved these changes

Assignees

@kavishsathia kavishsathia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kavishsathia @coveralls @monnss69 @CATISNOTSODIUM @RichDom2185 @martin-henz