-
Notifications
You must be signed in to change notification settings - Fork 32
Transition to Yarn Workspaces #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 152 commits
Commits
Show all changes
566 commits
Select commit
Hold shift + click to select a range
72e6c0e
Check working directory
leeyi45 8b06cf8
I have no idea why one evaluates to true and the other evalutes to false
leeyi45 fa85736
Check cwd
leeyi45 3841105
Remove all the windows directory stuff and just use yarn workspaces i…
leeyi45 f378383
Update test configs
leeyi45 cdf70e0
Try adding a new matcher for resolving paths
leeyi45 2bcf0dc
Update the buildtools tests for windows compatibility
leeyi45 a9f2d80
Add a "same path" comparer
leeyi45 e583162
Continue fixing tests to make them work on windows
leeyi45 f6847ad
Still fixing tests....
leeyi45 f11b4c4
Add some logging
leeyi45 773cd4c
Try and fix the markdown tree tests
leeyi45 ac00019
Fix the tsc thing
leeyi45 a2b03d9
Re-enable the full workflow
leeyi45 a08edba
Continue to try fix the doc server not building
leeyi45 21a0d30
Still trying to figure the docserver out
leeyi45 985d58a
Echo the changes value for docserver
leeyi45 388f14f
Use fromJSON
leeyi45 759a012
Returning a mapping doesn't work
leeyi45 90229db
Disable everything except for docserver
leeyi45 84a3c8f
Try using fromJSON in a different place
leeyi45 e1593c7
As a whole workflow, this should now work
leeyi45 6110d5c
Update deploy workflow
leeyi45 7e27aef
Update docs
leeyi45 e316080
Add the memory space option to lint:all
leeyi45 7117b7c
Remove unnecessary patch
leeyi45 ede60f0
Update lib/repotools/src/manifest.ts
RichDom2185 315a49e
Revert "Remove unnecessary patch"
RichDom2185 3e5b9b2
Reformat some Markdown files for readability
RichDom2185 d2ed1a5
Reformat more Markdown files
RichDom2185 0c8edb2
Reformat even more Markdown files
RichDom2185 b8b5ab2
Reformat remaining Markdown files
RichDom2185 25fe416
Update doc server and remove yarnhook
leeyi45 c0a6137
Add http server command to buildtools
leeyi45 e8b7ea1
Update libs and docs about focused installations
leeyi45 29e3198
Fix lint issue
leeyi45 dc62eba
Finally got linting code blocks in markdown files to work
leeyi45 16e46be
Fix dead links
leeyi45 c7e8765
Enable lint global to output stats too
leeyi45 e39dc33
Add a CSV formatter for ESLint statistics
leeyi45 1f1f9a4
Fix some docs
leeyi45 b30801a
Hide pathname from mqtt pic
leeyi45 b5e8328
Fix some flaws with the devserver
leeyi45 615f7b4
Update unittest bundle and tab to allow multiple and nested calls to …
leeyi45 4560af3
Reformat Markdown files
RichDom2185 5583e18
Fix AR bundle
RichDom2185 838ef37
Add a new action that rebuilds the tabs for the devserver if necessary
leeyi45 3833f37
Fix action always rebuilding artifact
leeyi45 b863da9
Will changing the order work?
leeyi45 0c50c75
Forgot to enable corepack
leeyi45 b518abd
Add manifest building
leeyi45 9c42e37
Cleanup
RichDom2185 c52eec3
Fix devserver workflow not working and modules-lib install taking for…
leeyi45 6a436b6
Add description to github actions package
leeyi45 11abc90
Time to figure out why playwright detection isn't working
leeyi45 a4e264a
Turns out I am just dumb and left playwright out of the curve tab's d…
leeyi45 ef48e95
Use headless install of playwright instead
leeyi45 78d3781
Miscellanous changes
leeyi45 51c5fb4
Update docs and lint configuration for quotes
leeyi45 1315c90
Fix the inconsistent semicolon delimiting in typescript types and int…
leeyi45 e61e287
Remove useless workspaces and modify templates to include all scripts
leeyi45 cd8845f
Test playwright caching
leeyi45 1d66fd2
Try another way to parse json
leeyi45 1960a43
Try installing the tab package
leeyi45 2e13ce2
Try focusing everything at once
leeyi45 4f04d86
Check if the playwright directory is found
leeyi45 2b96862
Fix error handling not working
leeyi45 df25d9b
Maybe this will work
leeyi45 9122f93
Try playwright tool caching
leeyi45 cc4a4ff
Use the workspace command instead
leeyi45 c937fa4
Fix using the wrong playwright option
leeyi45 086281d
Does adding the mkdirP call work?
leeyi45 a822167
Use cache instead of tool-cache
leeyi45 a638335
Remove tool-cache
leeyi45 b43125c
Restore everything else and stop using caching for playwright
leeyi45 138f19f
Add missing repotools tests
leeyi45 464d99c
Remove testing related tests since we can't really mock vite
leeyi45 6e28860
Update some dependencies
leeyi45 18b9db6
Fix it and test being able to be called recursively
leeyi45 75057b2
Add doc info on describe function titles
leeyi45 16a1834
Format the summary produced by the info action to be better
leeyi45 0eb51a9
Fix base url not working correctly
leeyi45 ace06f2
Fix the url not working again
leeyi45 286b1ff
Fix url handling again
leeyi45 b833da5
Add tests for rune bundle and tab
leeyi45 3861c2c
Update test coverage configuration
leeyi45 a52469e
Merge remote-tracking branch 'origin/tab-cleanup' into yarn-workspaces
leeyi45 ccbd65f
Add tests for plotly and painter tabs
leeyi45 b247e12
Fix issue with configs not being cloned properly
leeyi45 5e04913
Fix curve bundle functions and tests
leeyi45 db01b2e
Add anaglyph rune test
leeyi45 59babe6
Fix tests not working correctly
leeyi45 a903cc8
Add tests for sound and stereo_sound bundles
leeyi45 c7b3f09
Add tests to repl
leeyi45 641c8d7
Update some documentation
leeyi45 be6ae5f
Try adding a github actions reporter
leeyi45 b79c08b
Fix incorrect build
leeyi45 786aef1
Remove the requirement to build the reporter
leeyi45 f083a29
Try a version with actions/core bundled
leeyi45 6d3f074
Add the uncovered lines information
leeyi45 790805c
Fix linting and some other things
leeyi45 fa6982f
Sort test coverage output
leeyi45 dfcae9f
Try adding some colors
leeyi45 50731d6
More formatting
leeyi45 e53d0a1
Fix nested td in html
leeyi45 2ab4b64
Reformat uncovered lines list
leeyi45 4152dad
Hide uncovered lines in a summary
leeyi45 57914a5
Final modifications
leeyi45 43e69a4
Update documenation for the vitest coverage reporter
leeyi45 2e6738e
Remove the dependency on actions/core
leeyi45 59d59b1
Use fs directly since istanbul context writer doesn't support appending
leeyi45 feb1bd4
Add a summary reporter for tests
leeyi45 7981a8f
Fix broken paths
leeyi45 e40606d
Fix an undefined check?
leeyi45 a580b8f
Try another reporter implementation
leeyi45 3f74088
Fix continue to fix formatting
leeyi45 48952f4
Fix formatting again
leeyi45 90cf4d3
Fix test formatter
leeyi45 84d50f9
More formatting fixes
leeyi45 83f3c55
Found the way to get the file name
leeyi45 e5e1ff3
Fix filepath
leeyi45 48706cf
Add start time for test modules
leeyi45 0f693c4
Try to fix the start times
leeyi45 56839f4
Add slow indicator
leeyi45 a5280f5
Add docs about test coverage
leeyi45 718f769
Change defineTab type to be generic
leeyi45 c939817
Fix stereo sound tab not retrieving the correct module state
leeyi45 1f7206b
Update test reporter to follow the summary format
leeyi45 f9beead
Add the silent option to tests
leeyi45 fcc0332
Fix tests for curve and rune tabs and unittest
leeyi45 6888a81
Fix some oversight in eslint styles
leeyi45 d562ab0
Add tests for the unittest bundle mocking functions
leeyi45 95586c2
Add a constraint to prevent js-slang from being resolved to something…
leeyi45 192a99f
Add a paragraph on test file naming
leeyi45 a09707a
Fix the vitest reporter being written in cjs and tests
leeyi45 4873bfb
Use instanceof for type guards
leeyi45 9140a00
Try using a default import for the coverage reporter
leeyi45 4be62a4
Try using named imports
leeyi45 dd49bec
Try using ESM
leeyi45 10c2591
Revert to old coverage reporter
leeyi45 b0cb71b
Merge branch 'yarn-workspaces' of github.com:source-academy/modules i…
leeyi45 8b96204
Try this combination of ESM and CJS to see if it works
leeyi45 758ff97
FIx incorrect path to coverage reporter
leeyi45 52e1a67
FIx the typescript errors with the coverage reporter
leeyi45 6d794a7
Disable import/no-cycle rule to save linting time
leeyi45 53a621f
Update eslint to make use of the new concurrent option
leeyi45 bec27ff
Add rule to redirect imports to extra typings for commander
leeyi45 fada712
Fix tsc error
leeyi45 eca9e09
Use the minified version of the reporter
leeyi45 09e3a05
Update test configuration
leeyi45 62b34f5
Add more tests for actions
leeyi45 52314a8
Add tests and fix linting
leeyi45 67ca88c
FIx skipped tests displaying empty duration strings
leeyi45 14db79b
Try to fix the duration string again
leeyi45 840f23a
Try to fix the duration string again
leeyi45 079de28
Manually check the state of the test instead
leeyi45 54a5659
Separate the lint check into two different steps
leeyi45 2934fa3
Move linting step into the matrix
leeyi45 98a56b8
Revert "Move linting step into the matrix"
leeyi45 d192b0d
Revert "Separate the lint check into two different steps"
leeyi45 6ddcd6a
Update inaccurate test counts
leeyi45 fca8a69
Update documentation further
leeyi45 4528e57
Improve binary tree typing and add tests
leeyi45 1f13f92
Fix incorrect command test name
leeyi45 5b1a4e5
Fix types and tests for binary tree bundle
leeyi45 8d29a68
Fix documentation inconsistencies
leeyi45 dba9049
Add more documentation regarding errors and type-checking
leeyi45 197ba12
Remove unnecessary type assertions from code
leeyi45 9217498
Add two logging commands to the lint command
leeyi45 938f908
Fix wrong prefix for lint command
leeyi45 72e6c6a
Disable no unnecessary type assertions since it's not working properly
leeyi45 d0940bb
Add tests for pix_n_flix
leeyi45 402bc02
Fix incorrect react type package
leeyi45 ae77abd
Update docs to add description about versioning and writing documenta…
leeyi45 60f3ef9
Continue to fix linting and documentation issues
leeyi45 33a6466
Correct documentation errors
leeyi45 da5f3e5
Improve type-checking for sound bundle
leeyi45 bdb0a8f
Remove unnecessary calls to get_duration and get_wave
leeyi45 856855a
Update stereo_sound and sound bundle functions to include better type…
leeyi45 917dffe
Rename unittest test file
leeyi45 c1b21a8
Rename test files to include .test.
leeyi45 9c8bd1d
Update snapshots
leeyi45 d87b95c
Add developer documentation for bundles
leeyi45 22bbf6d
Modify the bundle specific documentations
leeyi45 208fb28
Fix broken links
leeyi45 9dc79fc
Add tests to sound
leeyi45 877fc54
Add tests to sound bundle
leeyi45 2dc93f2
minor fixes
leeyi45 bc31c25
Remove @vitest/browser package
leeyi45 2e46951
Add spell checking to documentation
leeyi45 0383b38
Update spellcheck configuration to exclude modules-lib
leeyi45 dc932c4
Fix dead link
leeyi45 c9540be
Update documentations
leeyi45 89b0fa9
Add a section documenting spell checking
leeyi45 1d73ed9
Fix the numbering
leeyi45 4b93345
Continue removing @vitest/browser
leeyi45 ff831b3
Fix incorrect path in tab template command
leeyi45 31ceecb
Fix tab template command adding version to bundle manifest
leeyi45 ebf5871
Use the direct import instead of the barrel lodash import
leeyi45 8ada78a
Try updating all of the testing packages
leeyi45 75546f0
Continue fixing broken tests
leeyi45 e693cf2
Fix tests for robot_simulation
leeyi45 3c75a52
Fix sound bundle tests
leeyi45 95fe02e
Fix repo tools tests
leeyi45 51ad799
Update tsconfigs to include noEmit true
leeyi45 aeeb356
Make manifest errors more informative
leeyi45 f8db3bf
Add eols to tsconfigs
leeyi45 a41708c
Split the list command into two
leeyi45 63a9c8c
Separate tests for list and validate command
leeyi45 9ced56f
Update documentation to reflect the new browser mode API
leeyi45 69bd79d
Improve documentation about testing
leeyi45 f9afb61
Update buildtools docs
leeyi45 2d0ba84
Update vitest to the version that doesn't need the path and fs module…
leeyi45 fd42523
Update coverage configuration
leeyi45 e4936a5
Merge branch 'yarn-workspaces' of github.com:source-academy/modules i…
leeyi45 ce0ded6
Fix coverage exclusion pattern excluding buildtools
leeyi45 9f2fbd3
Make sure to await render calls in tests
leeyi45 c90b94b
Use vi.stubGlobal instead Object.defineProperty
leeyi45 24e9a1e
Remove the need for noEmit on a per bundle basis
leeyi45 5151e50
Update some documentation
leeyi45 ae1721d
FIx broken test
leeyi45 425fa19
Minor fix to MultItemDisplay
leeyi45 2a6f2ce
Standardize Markdown formatting
RichDom2185 22d98c0
Fix SASS warnings
RichDom2185 6f8564e
Remove unused styles from devserver
RichDom2185 a26b645
Reformat all markdown files
RichDom2185 819b492
Bump node version
RichDom2185 4a91356
Update actions versions
RichDom2185 40b2670
Update editor settings and add recommended extensions
RichDom2185 5a968ef
Revert change to plotly functions.ts
leeyi45 d13f1dd
Merge branch 'yarn-workspaces' of github.com:source-academy/modules i…
leeyi45 d068fc9
Move vitest to ts files
leeyi45 e6aecba
Update testing configuration and documentation related to testing
leeyi45 bfe6c6a
Update an incorrect linting configuration
leeyi45 888e0c9
Update workflows to use node24
leeyi45 c9aa42d
Fix incorreect tsconfig for modules lib
leeyi45 3d977ac
Fix ESLint not correctly detecting tsconfig for vitest files
leeyi45 806aca4
Fix broken buildtools test
leeyi45 44647cc
Make the test include pattern a posix path instead of a windows path
leeyi45 bd408ce
Move test configuration utiliites from buildtools to repotools and fi…
leeyi45 b8b3693
Update some tests
leeyi45 9fca7f1
Update devserver vite configuration to include missing optimizeDeps
leeyi45 ac54bbf
Update docs to reflect that bundles can also use browser mode for tes…
leeyi45 b39a28f
Reformat markdown
RichDom2185 de1b2b6
Fix tsconfig
RichDom2185 24dde6e
Fix plotly breaking changes
RichDom2185 91c330f
Remove extraneous newline
RichDom2185 01edf58
Remove unused snapshots
RichDom2185 bf9a528
Remove old Jest snapshot
RichDom2185 cfa7b2c
Add termination workflow for easy branch protections
RichDom2185 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
leeyi45 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| yarn build --lint --tsc | ||
| yarn constraints | ||
| yarn workspaces foreach -ptR -j 5 --since --include "./src/{bundles,tabs}/*" run buildtools prebuild | ||
| yarn workspaces foreach -ptR -j 5 --since --include "./src/{bundles,tabs}/*" run test | ||
| yarn workspaces foreach -ptW --since --include "./{lib,devserver}/*" run lint | ||
| yarn workspaces foreach -ptW --since --include "./{lib,devserver}/*" run tsc | ||
| yarn workspaces foreach -ptW --since --include "./{lib,devserver}/*" run test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 20.11.1 | ||
| 22.16.0 |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "files.insertFinalNewline": true, | ||
| "json.schemas": [ | ||
| { | ||
| "fileMatch": ["src/bundles/**/manifest.json"], | ||
| "url": "./lib/repotools/src/manifest.schema.json" | ||
| }, | ||
| { | ||
| "fileMatch": ["tsconfig.json", "tsconfig.*.json"], | ||
| "schema": { | ||
| "allOf": [{ "$ref": "http://json.schemastore.org/tsconfig" }], | ||
| "properties": { | ||
| "typedocOptions": { | ||
| "allOf": [{ "$ref": "https://typedoc.org/schema.json" }] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.