Skip to content

code_style: general cleanup #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Jul 11, 2025

Various code improvements. The changes to QueryLocalChanges in particular make the code much easier to understand.

@love-linger
Copy link
Collaborator

I no longer plan to merge this kind of PR.

  1. There are too many code changes, which takes too much time to review.
  2. Sometimes I can't recall the issues that needed to be considered during the coding process, resulting in bugs, such as 2025.26 Can't UNSTAGE files from stage when checked Amend checkbox #1582, 2025.26 doesn't startup if the path has a space in it. #1576, d28bd92, etc.
  3. Most of them are about new syntax or variable initialization suggestions.

@NathanBaulch
Copy link
Contributor Author

No worries, I only submitted this because you were so quick and thorough at reviewing previous cleanup PRs. I wasn't aware there had been regressions.

@love-linger love-linger force-pushed the develop branch 6 times, most recently from 05dba32 to 6822ae3 Compare July 21, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants