enhance: Add "Move to New Window" and "Copy to New Window" options #1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced the user interface by adding new menu items for "Move to New Window" and "Copy to New Window" in various language files. Implemented the corresponding functionality in `Launcher.cs` to allow users to move or copy tabs to new windows.
- Introduced `IsSecondaryWindow` property and `OnRequestClose` event in the `Launcher` view model. - Updated the constructor to accept a boolean for secondary window status. - Modified `Quit` method to handle close requests for secondary windows. - Refactored `MoveToNewWindow` and `CopyToNewWindow` methods to streamline window creation. - Added `RegisterOnRequestClose` method in the `Launcher` view to manage close requests. - Updated `using` directives in `Launcher.axaml.cs` to include `Avalonia.Threading`.
There was a problem hiding this comment.
Pull Request Overview
This PR adds "Move to New Window" and "Copy to New Window" functionality to allow users to transfer repository tabs between windows. The implementation includes localized menu items across 15 language files and core functionality in the Launcher classes.
- Adds context menu options for moving/copying tabs to new windows
- Implements secondary window management with proper cleanup
- Provides localized strings for the new menu items across all supported languages
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ViewModels/Launcher.cs | Core functionality for window management and menu item creation |
| src/Views/Launcher.axaml.cs | Window lifecycle management and close event registration |
| src/Resources/Locales/*.axaml | Localized strings for new menu items (15 language files) |
[nitpick] The nested if-else structure could be simplified for better readability. Consider early return pattern: 'if (IsSecondaryWindow) { OnRequestClose?.Invoke(); return; }'
love-linger
force-pushed
the
develop
branch
3 times, most recently
from
370c592 to
a3ed066
Compare
…when it's not necessary (sourcegit-scm#1577) Signed-off-by: leo <[email protected]>
love-linger
force-pushed
the
develop
branch
2 times, most recently
from
05dba32 to
6822ae3
Compare
|
I don't plan to add support for multi-instance or multi-window features now since there are lots of bugs in this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the user interface by adding new menu items for "Move to New Window" and "Copy to New Window" in various language files. Implemented the corresponding functionality in
Launcher.csto allow users to move or copy tabs to new windows.